Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select][material-ui] Merge slotProps.paper with internal Paper props #38703

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

michaldudak
Copy link
Member

When MenuProps.slotProps.paper was provided to the Select, it replaced the internal props instead of merging them. This PR solves this.

Fixes #38700.

@michaldudak michaldudak added bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Aug 29, 2023
@michaldudak michaldudak requested a review from DiegoAndai August 29, 2023 11:53
@mui-bot
Copy link

mui-bot commented Aug 29, 2023

Netlify deploy preview

https://deploy-preview-38703--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 57e1fca

@michaldudak michaldudak force-pushed the select-paper-slotprops-merging branch from bbc7f04 to 57e1fca Compare August 29, 2023 15:35
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@michaldudak michaldudak merged commit 498bd93 into mui:master Aug 30, 2023
@michaldudak michaldudak deleted the select-paper-slotprops-merging branch August 30, 2023 07:04
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select] slotProps overrides entire default props
3 participants